Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1736#discussion_r94504740
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/StormSqlImpl.java ---
@@ -166,8 +161,7 @@ public void explain(Iterable<String> statements) throws
Exception {
SqlNode validate = planner.validate(parse);
RelNode tree = planner.convert(validate);
- // TODO: change to all attributes when we change to cost-based
planner
- String plan = RelOptUtil.toString(tree,
SqlExplainLevel.NON_COST_ATTRIBUTES);
+ String plan = StormRelUtils.explain(tree,
SqlExplainLevel.ALL_ATTRIBUTES);
System.out.println("plan>");
--- End diff --
That's a good idea, but not related to this change. I'll file an issue
regarding this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
