Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1736#discussion_r94504773
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/StormSqlImpl.java ---
@@ -113,18 +113,13 @@ public void submit(
} else if (node instanceof SqlCreateFunction) {
handleCreateFunction((SqlCreateFunction) node);
} else {
- DataContext dataContext = new StormDataContext();
- FrameworkConfig config = buildFrameWorkConfig();
- Planner planner = Frameworks.getPlanner(config);
- SqlNode parse = planner.parse(sql);
- SqlNode validate = planner.validate(parse);
- RelNode tree = planner.convert(validate);
- org.apache.storm.sql.compiler.backends.trident.PlanCompiler
compiler =
- new
org.apache.storm.sql.compiler.backends.trident.PlanCompiler(dataSources,
typeFactory, dataContext);
- TridentTopology topo = compiler.compile(tree);
+ QueryPlanner planner = new QueryPlanner(schema);
+ AbstractTridentProcessor processor = planner.compile(dataSources,
sql);
+ TridentTopology topo = processor.build(null);
--- End diff --
Just removed that parameter since it is no longer needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
