Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96725703
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -80,16 +76,14 @@
private transient KafkaSpoutRetryService retryService; //
Class that has the logic to handle tuple failure
private transient Timer commitTimer; //
timer == null for auto commit mode
private transient boolean initialized; //
Flag indicating that the spout is still undergoing initialization process.
- private transient KafkaRecordsFetcher<K, V> recordsFetcher; //
Class that encapsulates the logic of managing partitions and fetching records
// Initialization is only complete after the first call to
KafkaSpoutConsumerRebalanceListener.onPartitionsAssigned()
- private KafkaSpoutStreams kafkaSpoutStreams; //
Object that wraps all the logic to declare output fields and emit tuples
- private transient KafkaSpoutTuplesBuilder<K, V> tuplesBuilder; //
Object that contains the logic to build tuples for each ConsumerRecord
-
transient Map<TopicPartition, OffsetEntry> acked; // Tuples
that were successfully acked. These tuples will be committed periodically when
the commit timer expires, after consumer rebalance, or on close/deactivate
private transient Set<KafkaSpoutMessageId> emitted; //
Tuples that have been emitted but that are "on the wire", i.e. pending being
acked or failed
private transient Iterator<ConsumerRecord<K, V>> waitingToEmit;
// Records that have been polled and are queued to be emitted in the
nextTuple() call. One record is emitted per nextTuple()
private transient long numUncommittedOffsets; //
Number of offsets that have been polled and emitted but not yet been committed
+ private transient TopologyContext context;
--- End diff --
Nit: The rest of the file uses spaces for indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
