Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96726868
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -412,8 +401,12 @@ public void activate() {
private void subscribeKafkaConsumer() {
kafkaConsumer =
kafkaConsumerFactory.createConsumer(kafkaSpoutConfig);
- recordsFetcher = KafkaRecordsFetchers.create(kafkaSpoutConfig,
kafkaConsumer, topologyContext,
- new KafkaSpoutConsumerRebalanceListener());
+
+ kafkaSpoutConfig.getSubscription().subscribe(kafkaConsumer, new
KafkaSpoutConsumerRebalanceListener(), context);
+
+ // Initial poll to get the consumer registration process going.
+ // KafkaSpoutConsumerRebalanceListener will be called following
this poll, upon partition registration
+ kafkaConsumer.poll(0);
--- End diff --
Doesn't this belong in the automatic subscriptions? It's not necessary if
using manual partition assignment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
