Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1902#discussion_r98588501
  
    --- Diff: 
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/trident/TridentKafkaClientWordCountNamedTopics.java
 ---
    @@ -107,8 +113,12 @@ protected void run(String[] args) throws 
AlreadyAliveException, InvalidTopologyE
                         localSubmitter.submit(topic1Tp, tpConf, 
KafkaProducerTopology.newTopology(brokerUrl, topic1));
                         localSubmitter.submit(topic2Tp, tpConf, 
KafkaProducerTopology.newTopology(brokerUrl, topic2));
                         // Consumer
    +                    try {
                         localSubmitter.submit(consTpName, tpConf, 
TridentKafkaConsumerTopology.newTopology(
                                 localSubmitter.getDrpc(), 
newKafkaTridentSpoutOpaque()));
    +                    } catch (Exception e) {
    +                        e.printStackTrace();
    +                    }
     
                         // print
                         localSubmitter.printResults(15, 1, TimeUnit.SECONDS);
    --- End diff --
    
    If submit is failing, it doesn't make sense to execute this. Might be 
better to move this to the inside of try-catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to