Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98589751
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -47,70 +33,111 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class KafkaTridentSpoutEmitter<K,V> implements
IOpaquePartitionedTridentSpout.Emitter<List<TopicPartition>,
KafkaTridentSpoutTopicPartition, KafkaTridentSpoutBatchMetadata<K,V>>,
Serializable {
- private static final long serialVersionUID = -7343927794834130435L;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+import static
org.apache.storm.kafka.spout.KafkaSpoutConfig.FirstPollOffsetStrategy.EARLIEST;
+import static
org.apache.storm.kafka.spout.KafkaSpoutConfig.FirstPollOffsetStrategy.LATEST;
+import static
org.apache.storm.kafka.spout.KafkaSpoutConfig.FirstPollOffsetStrategy.UNCOMMITTED_EARLIEST;
+import static
org.apache.storm.kafka.spout.KafkaSpoutConfig.FirstPollOffsetStrategy.UNCOMMITTED_LATEST;
+public class KafkaTridentSpoutEmitter<K, V> implements
IOpaquePartitionedTridentSpout.Emitter<
+ List<TopicPartition>,
+ KafkaTridentSpoutTopicPartition,
+ KafkaTridentSpoutBatchMetadata<K, V>>,
+ Serializable {
+
+ private static final long serialVersionUID = -7343927794834130435L;
private static final Logger LOG =
LoggerFactory.getLogger(KafkaTridentSpoutEmitter.class);
// Kafka
private final KafkaConsumer<K, V> kafkaConsumer;
// Bookkeeping
private final KafkaTridentSpoutManager<K, V> kafkaManager;
+
// Declare some KafkaTridentSpoutManager references for convenience
private final long pollTimeoutMs;
private final KafkaSpoutConfig.FirstPollOffsetStrategy
firstPollOffsetStrategy;
private final RecordTranslator<K, V> translator;
private final Timer refreshSubscriptionTimer;
- public KafkaTridentSpoutEmitter(KafkaTridentSpoutManager<K,V>
kafkaManager, TopologyContext context) {
- this.kafkaManager = kafkaManager;
- this.kafkaManager.subscribeKafkaConsumer(context);
- refreshSubscriptionTimer = new Timer(500,
kafkaManager.getKafkaSpoutConfig().getPartitionRefreshPeriodMs(),
TimeUnit.MILLISECONDS);
+ private TopologyContext topologyContext;
- //must subscribeKafkaConsumer before this line
- kafkaConsumer = kafkaManager.getKafkaConsumer();
- translator = kafkaManager.getKafkaSpoutConfig().getTranslator();
+ public KafkaTridentSpoutEmitter(KafkaTridentSpoutManager<K,V>
kafkaManager, TopologyContext topologyContext, Timer refreshSubscriptionTimer) {
+ this.kafkaConsumer =
kafkaManager.createAndSubscribeKafkaConsumer(topologyContext);
+ this.kafkaManager = kafkaManager;
+ this.topologyContext = topologyContext;
+ this.refreshSubscriptionTimer = refreshSubscriptionTimer;
+ this.translator =
kafkaManager.getKafkaSpoutConfig().getTranslator();
final KafkaSpoutConfig<K, V> kafkaSpoutConfig =
kafkaManager.getKafkaSpoutConfig();
- pollTimeoutMs = kafkaSpoutConfig.getPollTimeoutMs();
- firstPollOffsetStrategy =
kafkaSpoutConfig.getFirstPollOffsetStrategy();
+ this.pollTimeoutMs = kafkaSpoutConfig.getPollTimeoutMs();
+ this.firstPollOffsetStrategy =
kafkaSpoutConfig.getFirstPollOffsetStrategy();
LOG.debug("Created {}", this);
}
+ /**
+ * Creates instance of this class with default 500 millisecond refresh
subscription timer
+ */
+ public KafkaTridentSpoutEmitter(KafkaTridentSpoutManager<K,V>
kafkaManager, TopologyContext topologyContext) {
+ this(kafkaManager, topologyContext, new Timer(500,
+
kafkaManager.getKafkaSpoutConfig().getPartitionRefreshPeriodMs(),
TimeUnit.MILLISECONDS));
+ }
+
@Override
public KafkaTridentSpoutBatchMetadata<K, V>
emitPartitionBatch(TransactionAttempt tx, TridentCollector collector,
- KafkaTridentSpoutTopicPartition partitionTs,
KafkaTridentSpoutBatchMetadata<K, V> lastBatch) {
- LOG.debug("Emitting batch: [transaction = {}], [partition = {}],
[collector = {}], [lastBatchMetadata = {}]",
- tx, partitionTs, collector, lastBatch);
+ KafkaTridentSpoutTopicPartition currBatchPartition,
KafkaTridentSpoutBatchMetadata<K, V> lastBatch) {
- final TopicPartition topicPartition =
partitionTs.getTopicPartition();
+ LOG.debug("Processing batch: [transaction = {}],
[currBatchPartition = {}], [lastBatchMetadata = {}], [collector = {}]",
+ tx, currBatchPartition, lastBatch, collector);
+
+ final TopicPartition currBatchTp =
currBatchPartition.getTopicPartition();
+ final Set<TopicPartition> assignments = kafkaConsumer.assignment();
KafkaTridentSpoutBatchMetadata<K, V> currentBatch = lastBatch;
Collection<TopicPartition> pausedTopicPartitions =
Collections.emptySet();
- try {
- // pause other topic partitions to only poll from current
topic partition
- pausedTopicPartitions = pauseTopicPartitions(topicPartition);
+ if (assignments == null ||
!assignments.contains(currBatchPartition.getTopicPartition())) {
+ LOG.debug("SKIPPING processing batch: [transaction = {}],
[currBatchPartition = {}], [lastBatchMetadata = {}], " +
--- End diff --
Is it OK to have this as debug? If it indicates that odd thing is
happening, better to have this as warn or even higher.
I'm not familiar with current storm-kafka-client so just would like to
check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
