Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r99889319
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -319,8 +320,10 @@ private boolean
emitTupleIfNotEmitted(ConsumerRecord<K, V> record) {
} else {
collector.emit(tuple, msgId);
}
- emitted.add(msgId);
- numUncommittedOffsets++;
+ if(!consumerAutoCommitMode){//only need to track in
none-AutoCommitMode
+ emitted.add(msgId);
--- End diff --
Sorry, nevermind. Just occured to me that Storm will call ack immediately
if it's configured that way :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
