Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r99891846
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -107,7 +107,8 @@ public void open(Map conf, TopologyContext context,
SpoutOutputCollector collect
// Offset management
firstPollOffsetStrategy =
kafkaSpoutConfig.getFirstPollOffsetStrategy();
- consumerAutoCommitMode =
kafkaSpoutConfig.isConsumerAutoCommitMode();
+ // with AutoCommitMode, topology works in 'At-Most-Once' mode, and
offset will be periodically committed in the background by Kafka consumer
--- End diff --
Can we add this to the readme
https://github.com/apache/storm/blob/master/docs/storm-kafka-client.md
We don't document auto-commit there, but if people are using it we should
have something explaining how to use it and the ramifications of turning it on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
