Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1924#discussion_r99876099
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -289,6 +293,13 @@ private void doSeekRetriableTopicPartitions() {
                     kafkaConsumer.seek(rtp, 
acked.get(rtp).getCommittedOffset() + 1);    // Seek to last committed offset
                 }
             }
    +        
    +        if(!retriableTopicPartitions.isEmpty()) {
    +            //Pause other partitions for this poll so 
maxUncommittedPartitions isn't exceeded by too much
    +            Set<TopicPartition> assignment = new 
HashSet<>(kafkaConsumer.assignment());
    --- End diff --
    
    let's call this variable 'paused' or something along those lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to