Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r99950879
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -289,6 +293,13 @@ private void doSeekRetriableTopicPartitions() {
kafkaConsumer.seek(rtp,
acked.get(rtp).getCommittedOffset() + 1); // Seek to last committed offset
}
}
+
+ if(!retriableTopicPartitions.isEmpty()) {
+ //Pause other partitions for this poll so
maxUncommittedPartitions isn't exceeded by too much
--- End diff --
I thought about it some more, and I don't think it's necessary. As long as
we only have to guarantee that maxUncommittedOffsets isn't exceeded by more
than maxPollRecords per partition, it should be fine to consume from all
partitions. I'll remove this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
