Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1942
  
    @pasalkarsachin1 @roshannaik 
    Two things from me...
    
    1. We should check that it works with Flux. In other words, if Flux doesn't 
support instantiating Class object and passing it, the change just breaks 
backward compatibility.
    
    2. To be honest, accepting alias and class in one method doesn't look 
intuitive. Users should memorize the alias (TEXT, SEQ) to use. Instead of doing 
this, why not adding shortcut methods so that IDE can help for us? Like 
`text()`, `sequence()` or a bit more longer name if it doesn't feel enough. 
Other options we can create Enum for known implementations and full class name 
for others, but the former looks simpler unless we're aliasing too much.
    
    cc. @arunmahadevan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to