Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
@HeartSaVioR
> For point 2 I suggest adding shortcut, not removing previous one.
Providing FQDN is not easiest way to do so we can make some implementations
taking precedence and support it via easiest way.
IMHO providing shortcut method is easiest (or similar to providing enum),
and providing enum is good enough, and receiving only FQDN is not convenient,
but just has to use. First two things make IDE providing various hints, and the
last thing doesn't.
Adding it to enum or even providing shortcut method will be done in 10
lines. I don't think it gives contributors more extra works, but we might need
to guide it properly.`
My intention was never to use FQCN it was just to use className rather than
Constants. Even you look at my code I am just using class name.
```java
setReader(Class<? extends FileReader> reader)
```
However what you are suggesting is in HdfsSpout I should add something like
below
```java
public hdfsSpout useTextFileReader() {
this.readerType = TextFileReader.class;
return this;
}
public hdfsSpout useSequenceFileReader() {
this.readerType = SequenceFileReader.class;
}
```
Also have a way to provide way to support FQCN, Correct?
If everyone agrees I will do the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
