I will fix it ASAP. @Bobby, please reply to my PR comment, and I will submit a patch ASAP.
Hugo > On Feb 22, 2017, at 10:45 AM, Bobby Evans <[email protected]> wrote: > > Yes I looked into it and what Hugo found is a blocker. We need to get it > fixed before we release. > > > - Bobby > > On Wednesday, February 22, 2017, 12:03:07 PM CST, Bobby Evans > <[email protected]> wrote:I think we should pull them in. Kafka is > a critical part of storm and if the examples don't work that it bad. > > > - Bobby > > On Wednesday, February 22, 2017, 11:56:56 AM CST, P. Taylor Goetz > <[email protected]> wrote:What are other’s thoughts on including the patch > Hugo mentioned below? Cut another RC, or proceed with the current one? > > -Taylor > >> On Feb 22, 2017, at 12:41 PM, Hugo Da Cruz Louro <[email protected]> >> wrote: >> >> +1 (non binding) >> >> I found out that the Storm Kafka Client Test Topologies were throwing >> SerializationException. I have submitted two patches for >> master<https://github.com/apache/storm/pull/1959> and 1.x-branch >> <https://github.com/apache/storm/pull/1958> . It would be good if we could >> merge this before the release, but it isn’t a blocker. >> >> Summary of Tests >> - unzipped .zip and tar.gz sources and binaries >> - mvn clean install unzipped sources >> - created uber jar for storm-solr and storm-kafka-client using pom.xml under >> examples directory (since artifacts not published to maven yet, it required >> the sources to first be installed in local maven repo) >> - tested storm-solr and storm-kafka-client using bundled test topologies, in >> local and remote cluster mode (everything is working fine after these two >> patches for master<https://github.com/apache/storm/pull/1959> and 1.x-branch >> <https://github.com/apache/storm/pull/1958> to fix a SerializationException) >> - killed and restarted zookeeper with nimbus and supervisors up and it >> recovered as expected >> >> Thanks, >> Hugo >> >> On Feb 21, 2017, at 7:47 AM, Bobby Evans >> <[email protected]<mailto:[email protected]>> wrote: >> >> +1 ran some basic tests on a distributed cluster. Built from source and all >> unit tests passed. >> >> >> - Bobby >> >> On Sunday, February 19, 2017, 8:38:59 PM CST, Xin Wang >> <[email protected]<mailto:[email protected]>> wrote:+1 Ran some >> tests in cluster mode. And I saw the js RAT issue has been >> fixed by Jungtaek. >> >> - Xin >> >> 2017-02-20 8:30 GMT+08:00 Jungtaek Lim >> <[email protected]<mailto:[email protected]>>: >> >> We've been introducing new changes via release note news. I'm not sure >> Taylor already wrote one, but if he didn't, I'm happy to simply describe >> it. >> >> Diff-ing docs directory between 1.0.x branch (or 1.0.3) and 1.x branch >> (1.1.0 rc1) might help to determine the improvement or new features. >> >> - Jungtaek Lim (HeartSaVioR) >> >> 2017년 2월 19일 (일) 오전 2:15, Julien Nioche >> <[email protected]<mailto:[email protected]>>님이 >> 작성: >> >> Hi guys, >> >> I can't find a description of how 1.1.x differs from 1.0.x, is that >> available somewhere? >> >> BTW all the versions on JIRA are marked as 'unreleased' >> >> Thanks >> >> Julien >> >> On 18 February 2017 at 12:16, Jungtaek Lim >> <[email protected]<mailto:[email protected]>> wrote: >> >> +1 (binding) >> >> source >> >> - verify file (signature, MD5, SHA) >> -- source, tar.gz : OK >> -- source, zip : OK >> >> - extract file >> -- source, tar.gz : OK >> -- source, zip : OK >> >> - diff-ing extracted files between tar.gz and zip : OK >> >> - build source with JDK 7 >> -- source, tar.gz : seeing RAT issue, others are OK >> >> - build source dist >> -- source, tar.gz : OK >> >> - build binary dist >> -- source, tar.gz : OK >> >> binary >> >> - verify file (signature, MD5, SHA) >> -- binary, tar.gz : OK >> -- binary, zip : OK >> >> - extract file >> -- binary, tar.gz : OK >> -- binary, zip : OK >> >> - diff-ing extracted files between tar.gz and zip : OK >> >> - launch daemons : OK >> - run RollingTopWords (local) : OK >> - run RollingTopWords (remote) : OK >> - activate / deactivate / rebalance / kill : OK >> - logviewer (worker dir, daemon dir) : OK >> - change log level : OK >> - thread dump, heap dump, restart worker : OK >> - log search : OK >> - run WordCountTopology (multilang, remote) : OK >> - run StatefulTopology (local) : OK >> - run StatefulTopology (remote) : OK >> - run StatefulWindowingTopology (remote) : OK >> >> - run Storm SQL features (with --artifacts) : OK (via testing Kafka & >> csv/tsv schema) >> >> I've seen RAT issue from newly added js files, but it's not about >> LICENSE >> issue, just exclusion from RAT plugin is missing. (I'll take care of it >> immediately.) >> >> Thanks, >> Jungtaek Lim (HeartSaVioR) >> >> 2017년 2월 18일 (토) 오전 4:42, P. Taylor Goetz >> <[email protected]<mailto:[email protected]>>님이 작성: >> >> This is a call to vote on releasing Apache Storm 1.1.0 (rc1) >> >> Full list of changes in this release: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ >> plain;f=CHANGELOG.md;hb=17a2017fb644e353fb2a0f5bf50d400ee28036ba >> >> The tag/commit to be voted upon is v1.1.0: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h= >> >> 75b7d808d10674ff580beb031ae970fe94e97615;hb= >> 17a2017fb644e353fb2a0f5bf50d40 >> 0ee28036ba >> >> The source archive being voted upon can be found here: >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. >> 1.0-rc1/apache-storm-1.1.0-src.tar.gz >> >> Other release files, signatures and digests can be found here: >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.1.0-rc1/ >> >> The release artifacts are signed with the following key: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ >> plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >> >> The Nexus staging repository for this release is: >> >> https://repository.apache.org/content/repositories/ >> orgapachestorm-1045 >> >> Please vote on releasing this package as Apache Storm 1.1.0. >> >> When voting, please list the actions taken to verify the release. >> >> This vote will be open for at least 72 hours. >> >> [ ] +1 Release this package as Apache Storm 1.1.0 >> [ ] 0 No opinion >> [ ] -1 Do not release this package because... >> >> Thanks to everyone who contributed to this release. >> >> -Taylor >> >> >> >> >> -- >> >> *Open Source Solutions for Text Engineering* >> >> http://www.digitalpebble.com >> http://digitalpebble.blogspot.com/ >> #digitalpebble <http://twitter.com/digitalpebble> >>
