Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r103352827
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -268,12 +268,11 @@ private Builder(Builder<?, ?> builder,
SerializableDeserializer<K> keyDes, Class
/**
* The maximum number of records a poll will return.
- * Will only work with Kafka 0.10.0 and above.
+ * This is limited by maxUncommittedOffsets, since it doesn't make
sense to allow larger polls than the spout is allowed to emit
+ * Please note that maxPollRecords effectively defines how far
past the last committed offset the spout will be allowed to read, if there are
failed tuples to retry.
--- End diff --
what do you mean by "if there are failed tuples to retry" ? I am not quite
following what you mean in here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
