Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106532445
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -404,6 +407,14 @@ private Builder(Builder<?, ?> builder,
SerializableDeserializer<K> keyDes, Class
}
public KafkaSpoutConfig<K,V> build() {
+
+ Number maxPollRecords =
(Number)kafkaProps.get(ConsumerConfig.MAX_POLL_RECORDS_CONFIG);
+ if(maxPollRecords == null) {
+ setMaxPollRecords(maxUncommittedOffsets);
--- End diff --
@srdo I don't agree with this. If the user does not set
MAX_POLL_RECORDS_CONFIG, this value should keep its Kafka default. It should
not silently be set to maxUncommittedOffsets. They are two unrelated things,
although I agree that MAX_POLL_RECORDS_CONFIG should not exceed
maxUncommittedOffsets
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
