Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106689294
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -270,17 +272,40 @@ public void setWaitingToEmit(ConsumerRecords<K,V>
consumerRecords) {
// ======== poll =========
private ConsumerRecords<K, V> pollKafkaBroker() {
- doSeekRetriableTopicPartitions();
- if (refreshSubscriptionTimer.isExpiredResetOnTrue()) {
- kafkaSpoutConfig.getSubscription().refreshAssignment();
+ Set<TopicPartition> retriableTopicPartitions =
doSeekRetriableTopicPartitions();
+ Set<TopicPartition> partitionsToPause =
getPartitionsToPauseToEnforceUncommittedOffsetsLimit(retriableTopicPartitions);
--- End diff --
I wasn't sure if calling resume() after every poll() might be expensive,
but it appears to just set a flag in the consumer. I'll change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
