Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106584890
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,9 +219,20 @@ public void setBlobMeta(String key, SettableBlobMeta
meta, Subject who) throws A
@Override
public void deleteBlob(String key, Subject who) throws
AuthorizationException, KeyNotFoundException {
validateKey(key);
- checkForBlobOrDownload(key);
- SettableBlobMeta meta = getStoredBlobMeta(key);
- _aclHandler.hasPermissions(meta.get_acl(), WRITE, who, key);
+
+ boolean checkPermission = true;
+ try {
+ checkForBlobOrDownload(key);
--- End diff --
Maybe we would need to check ZK and set checkPermission to false.
If there's race condition so ZK node didn't exist but added later, we might
skip pulling latest information and delete the blob in local anyway, but it
should be occurred only from standby Nimbus and the blob will be re-pulled at
next sync up.
I'll make appropriate change. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
