Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106349077
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,9 +219,20 @@ public void setBlobMeta(String key, SettableBlobMeta
meta, Subject who) throws A
@Override
public void deleteBlob(String key, Subject who) throws
AuthorizationException, KeyNotFoundException {
validateKey(key);
- checkForBlobOrDownload(key);
- SettableBlobMeta meta = getStoredBlobMeta(key);
- _aclHandler.hasPermissions(meta.get_acl(), WRITE, who, key);
+
+ boolean checkPermission = true;
+ try {
+ checkForBlobOrDownload(key);
--- End diff --
Sorry I was mistaken... Even if there's no key on ZK, KeyNotFoundException
is not thrown.
KeyNotFoundException is thrown only when there's race condition between ZK
node update and removing node from ZK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
