Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107529960
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -273,11 +273,9 @@ public void setWaitingToEmit(ConsumerRecords<K,V>
consumerRecords) {
// ======== poll =========
private ConsumerRecords<K, V> pollKafkaBroker() {
Set<TopicPartition> retriableTopicPartitions =
doSeekRetriableTopicPartitions();
- Set<TopicPartition> partitionsToPause =
getPartitionsToPauseToEnforceUncommittedOffsetsLimit(retriableTopicPartitions);
try{
- if(!partitionsToPause.isEmpty()) {
- kafkaConsumer.pause(partitionsToPause);
- }
+ //Pause all partitions with no retriable messages
+
pauseNonRetriablePartitionsToEnforceUncommitedOffsetsLimit(retriableTopicPartitions);
--- End diff --
retriableTopicPartitions could be inlined, but no big deal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
