GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2118
STORM-2516: Fix timing issues with testPrepareLateTupleStreamWithoutBâ¦
â¦uilder
The test was sleeping a bit and hoping that WaterMarkEventGenerator.run()
had been run by the executor in that class before the test woke up. Sometimes
that wasn't happening. Instead we're calling the method manually now, like the
rest of the tests involving that class.
I also fixed the checkstyle violations in WaterMarkEventGenerator.
As far as I can tell, the lastWatermarkTs variable in
WaterMarkEventGenerator should be volatile or an AtomicLong, since it is being
written to in run() with the expectation that it can be seen by the thread
calling track().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2516
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2118
----
commit 9a4d10efccb9b60746b80250f292a95c1f1f0f5a
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-05-16T19:27:41Z
STORM-2516: Fix timing issues with testPrepareLateTupleStreamWithoutBuilder
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
