Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2147#discussion_r119422491
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -170,10 +182,13 @@ private void initialize(Collection<TopicPartition> 
partitions) {
                     final long fetchOffset = doSeek(tp, committedOffset);
                     setAcked(tp, fetchOffset);
                 }
    -            initialized = true;
    +
    +            task.start();
    --- End diff --
    
    As far as I recall the KafkaConsumer won't let you commit messages to 
partitions the consumer is not assigned, so committing after 
onPartitionsRevoked won't work. I think it would be a nicer solution to 
eliminate most rebalances by switching to manual partition assignment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to