Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119449375
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -170,10 +182,13 @@ private void initialize(Collection<TopicPartition>
partitions) {
final long fetchOffset = doSeek(tp, committedOffset);
setAcked(tp, fetchOffset);
}
- initialized = true;
+
+ task.start();
--- End diff --
Huh, you're right. Learn something every day :)
We already have manual assignment implementations ready to go
[here](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ManualPartitionNamedSubscription.java)
and
[here](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ManualPartitionPatternSubscription.java),
the user just has to configure the spout to use them with one of these
builders
https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java#L136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
