Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2148#discussion_r120132118
--- Diff: storm-client/src/jvm/org/apache/storm/task/TopologyContext.java
---
@@ -57,13 +57,14 @@
private Map<String, Object> _executorData;
private Map<Integer,Map<Integer, Map<String, IMetric>>>
_registeredMetrics;
private AtomicBoolean _openOrPrepareWasCalled;
-
+ private Map<String, Long> _blobToLastKnownVersion;
public TopologyContext(StormTopology topology,
Map<String, Object> topoConf,
Map<Integer, String> taskToComponent,
Map<String, List<Integer>>
componentToSortedTasks,
Map<String, Map<String, Fields>>
componentToStreamToFields,
+ Map<String, Long> blobToLastKnownVersion,
--- End diff --
So this is a little odd in that we send the versions to all of the children
by passing in a variable that we expect to change behind the scenes. I think
it would be good to call that out in some comments both in the constructor
here, and on field too so it is obvious here in the code what is happening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
