Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2148#discussion_r120130165
  
    --- Diff: storm-client/src/jvm/org/apache/storm/task/TopologyContext.java 
---
    @@ -57,13 +57,14 @@
         private Map<String, Object> _executorData;
         private Map<Integer,Map<Integer, Map<String, IMetric>>> 
_registeredMetrics;
         private AtomicBoolean _openOrPrepareWasCalled;
    -
    +    private Map<String, Long> _blobToLastKnownVersion;
    --- End diff --
    
    Can we remove the `_` at the beginning.  I know it matches the rest of the 
file but we are moving away from this style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to