Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1950#discussion_r124184421
  
    --- Diff: docs/State-checkpointing.md ---
    @@ -70,6 +70,46 @@ json config with the following properties.
         }
     }
     ```
    + 
    +For Redis Cluster state this is a json config with the following 
properties.
    + 
    +```
    + {
    +   "keyClass": "Optional fully qualified class name of the Key type.",
    +   "valueClass": "Optional fully qualified class name of the Value type.",
    +   "keySerializerClass": "Optional Key serializer implementation class.",
    +   "valueSerializerClass": "Optional Value Serializer implementation 
class.",
    +   "jedisClusterConfig": {
    +     "nodes": ["localhost:7379", "localhost:7380", "localhost:7381"],
    +     "timeout": 2000,
    +     "maxRedirections": 5
    +   }
    + }
    +```
    +
    +NOTE: If you used Redis state with Storm version 1.1.0 or earlier, you 
would need to also migrate your state since the representation of state has 
changed  
    --- End diff --
    
    I think it will throw exception because state will not be converted 
properly, but there's no code to determine State version for now. Adding state 
version to the checkpoint spout state might be the one way to do this. I'll 
look into more about how we can handle this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to