Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1950#discussion_r124186379
--- Diff:
storm-core/src/jvm/org/apache/storm/state/DefaultStateEncoder.java ---
@@ -15,27 +15,23 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.storm.redis.utils;
+package org.apache.storm.state;
import com.google.common.base.Optional;
-import org.apache.commons.codec.binary.Base64;
-import org.apache.storm.state.DefaultStateSerializer;
-import org.apache.storm.state.Serializer;
-
/**
- * Helper class for encoding/decoding redis key values.
+ * Helper class for encoding/decoding key values.
*/
-public class RedisEncoder<K, V> {
+public class DefaultStateEncoder<K, V> {
--- End diff --
We're already exposing Serializer for key and value, so not sure we want to
have another interface and implementations here. Do we want to have encoder for
storage which doesn't support binary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
