Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2165#discussion_r124716042
--- Diff: bin/storm.py ---
@@ -94,7 +94,7 @@ def init_storm_env():
CONFFILE = ""
JAR_JVM_OPTS = shlex.split(os.getenv('STORM_JAR_JVM_OPTS', ''))
JAVA_HOME = os.getenv('JAVA_HOME', None)
-JAVA_CMD = 'java' if not JAVA_HOME else os.path.join(JAVA_HOME, 'bin',
'java')
+JAVA_CMD = 'java' if not JAVA_HOME else os.path.join(JAVA_HOME, 'bin',
'java' if not is_windows() else "java.exe")
--- End diff --
This one-liner becomes a bit complicated now. Could we expand this to
multiple lines?
And isn't the difference between non-windows and windows be 'java' or
'java.exe'? I mean `java vs java.exe` or `<JAVA_HOME>/bin/java vs
<JAVA_HOME>\bin\java.exe` might be correct whereas this line doesn't do the
thing. Please let me know if I'm missing here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
