Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2165#discussion_r124969263
--- Diff: bin/storm.py ---
@@ -66,6 +66,12 @@ def init_storm_env():
for option in options:
value = config.get('environment', option)
os.environ[option] = value
+
+def get_java_cmd():
--- End diff --
The one liner should have done the same thing, except when JAVA_HOME wasn't
set. But in that case it's okay to just call "java", since you don't have to
postfix with ".exe" for binaries on the PATH in Windows. I agree that this is
better though :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
