Github user ecararus commented on a diff in the pull request:
https://github.com/apache/storm/pull/2228#discussion_r128616112
--- Diff: storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java ---
@@ -107,13 +109,14 @@ public static NimbusClient
getConfiguredClientAs(Map<String, Object> conf, Strin
}
asUser = (String) conf.get(Config.STORM_DO_AS_USER);
}
+ ConfigValidation.validateFields(conf);
- List<String> seeds;
- if(conf.containsKey(Config.NIMBUS_HOST)) {
+ List<String> seeds = Lists.newArrayList();
--- End diff --
By default seeds will be empty and will be populated only if NIMBUS_HOST or
NIMBUS_SEEDS will be configured. in case if both missing an exception will [be
thrown
here](https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java#L153).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
