Hi Roshan, I guess rebasing could be necessary even while in review phase, so personally I'd rather see the PR first even it has merge conflict between origin master branch, and have review process with changes in PR, and address once review process is done.
If you want to hold off commits just before you submit a pull request, and you expect to submit it in several days, I'm also OK to wait for that. I just would like to ensure that holding doesn't stay longer. Thanks, Jungtaek Lim (HeartSaVioR) 2017년 7월 24일 (월) 오전 7:40, Roshan Naik <[email protected]>님이 작성: > Storm Devs, > My PR for STORM-2306 (messaging subsystem redesign) is almost ready. Not > surprisingly, this PR brings extensive modifications in storm-client module > and touches lightly on some others. > > Just finished manually rebasing my local changes (to ~90 files) from an > old version of master on to the latest master this Fri… but shortly after > I was done, more commits came into storm-client and need some manual > reconciling .. so it’s a bit difficult to keep up with. > > So, would like to request committers and contributors looking to make > changes in this critical module to either wait for this PR to go through or > work with me to see if we can work something out if its critical. > > Changes related to core areas like Disruptor, Metrics, Credential updates, > Worker, Executor, Task, Bolt/Spout output collectors/executors, ACKing etc > are areas with very high likelihood of merge conflicts. > > If there are better alternative ideas happy to consider. > Thanks for understanding, > > -roshan >
