Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r129566713
  
    --- Diff: 
examples/storm-perf/src/main/java/org/apache/storm/perf/ConstSpoutIdBoltNullBoltTopo.java
 ---
    @@ -76,6 +76,8 @@ public static StormTopology getTopology(Map<String, 
Object> conf) {
         public static void main(String[] args) throws Exception {
             int runTime = -1;
             Config topoConf = new Config();
    +        topoConf.put(Config.TOPOLOGY_SPOUT_RECVQ_SKIPS, 8);
    --- End diff --
    
    If we are setting this for all of the perf tests, then why is it not the 
default? Having a benchmark that does not show what people will get out of the 
box feels a bit fishy to me, even though everyone does it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to