GitHub user srdo opened a pull request:

    STORM-2689: Simplify dependency configuration for storm-kafka-example…

    …s, storm-kafka-client-examples and storm-elasticsearch-examples
    The basic problem is that provided.scope doesn't allow for setting a 
different scope for storm-client compared to the other dependencies. Right now 
you can either build a jar with all dependencies + storm-client, which you can 
only use to run LocalCluster topologies, or a jar without storm-client that is 
also missing a bunch of other dependencies.
    We could add another Maven profile or property like we do with 
provided.scope for IntelliJ in order to allow users to produce a jar without 
e.g. kafka-clients, but I think making running the examples as simple as 
possible is attractive.
    I think the easiest solution is to just produce a fat jar by default. This 
also seems to be how the rest of the examples work. 

You can merge this pull request into a Git repository by running:

    $ git pull STORM-2689

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2268
commit 145026ec555cc543ce4603d77396eb996f2575af
Author: Stig Rohde Døssing <>
Date:   2017-08-08T11:04:04Z

    STORM-2689: Simplify dependency configuration for storm-kafka-examples and 


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to