Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2270
  
    Logically it looks good. Only consideration is the implementation of 
chooseTasks(), given that it is critical path. The method will do concurrent 
hash map lookup tasks + 2 (including containsKey) times, which might be heavy 
for handling number of requests.
    
    Do you have any performance test result, like TVL with various rate? Maybe 
you want to optimize to catch up with other groupers, given that we are doing 
various optimization for other groupers implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to