Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2282#discussion_r133973275
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTupleListener.java
---
@@ -0,0 +1,48 @@
+package org.apache.storm.kafka.spout;
+
+import java.io.Serializable;
+import java.util.List;
+
+
+/**
+ * The KafkaTupleListener handles state changes of a kafka tuple inside a
KafkaSpout.
+ */
+public interface KafkaTupleListener extends Serializable {
--- End diff --
It might be useful to have a prepare method on this interface too, in case
implementations need to instantiate something that can't be serialized, e.g. a
KafkaProducer. I'm also wondering if it would be useful to be able to emit dead
tuples to a different stream as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
