Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2282#discussion_r134125885
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -363,6 +369,7 @@ private boolean emitTupleIfNotEmitted(ConsumerRecord<K,
V> record) {
} else {
collector.emit(tuple, msgId);
}
+ tupleListener.onEmit(tuple, msgId);
--- End diff --
Is it intended that this isn't called in auto commit mode? I would
understand why we wouldn't want to call it there, but I think we should maybe
add a note to the interface so it's obvious to users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
