Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2199#discussion_r135621982
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -792,6 +792,12 @@
public static final String ISOLATION_SCHEDULER_MACHINES =
"isolation.scheduler.machines";
/**
+ * Configuration elements for scheduler config loader.
+ */
+ @isMapEntryType(keyType = String.class, valueType = String.class)
--- End diff --
So I made a mistake. I thought initially that each of the configs in
`ConfigLoaderConfiguration` were regular configs under storm.yaml. I should
have read the code more closely, because they actually are sub-configs under
"scheduler.config.loader.params".
I don't really like them being sub configs because they don't get
validated. Which was the entire point of me asking you to add them into the
Validated ServiceLoader. I also don't see a lot of value in having
```yaml
scheduler.config.loader.params:
scheduler.config.loader.uri:
"artifactory+http://artifactory.my.company.com:8000/artifactory/configurations/clusters/my_cluster/ras_pools";
scheduler.config.loader.timeout.sec: 30
```
over
```yaml
scheduler.config.loader.uri:
"artifactory+http://artifactory.my.company.com:8000/artifactory/configurations/clusters/my_cluster/ras_pools";
scheduler.config.loader.timeout.sec: 30
```
Could we change it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
