Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2199#discussion_r135624834
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/utils/ArtifactoryConfigLoader.java
---
@@ -0,0 +1,416 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.scheduler.utils;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.net.URI;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Map;
+import org.apache.http.HttpEntity;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.HttpClient;
+import org.apache.http.client.ResponseHandler;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.client.utils.URIBuilder;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.http.util.EntityUtils;
+import org.apache.storm.Config;
+import org.apache.storm.utils.Time;
+import org.json.simple.JSONArray;
+import org.json.simple.JSONObject;
+import org.json.simple.parser.JSONParser;
+import org.json.simple.parser.ParseException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.yaml.snakeyaml.Yaml;
+import org.yaml.snakeyaml.constructor.SafeConstructor;
+
+/**
+ * A dynamic loader for that can load scheduler configurations for user
resource guarantees from Artifactory.
+ *
+ * <p>Configuration items for this config loader are passed in via config
settings in
+ * each scheduler that has a configurable loader.
+ *
+ * <p>For example, the resource aware scheduler has configuration items
defined in DaemonConfig.java
+ * that allow a user to configure which implementation of IConfigLoader to
use to load
+ * specific scheduler configs as well as any parameters to pass into the
prepare method of
+ * that configuration.
+ *
+ * <p>resource.aware.scheduler.user.pools.loader can be set to
org.apache.storm.scheduler.utils.ArtifactoryConfigLoader
+ *
+ * <p>and then resource.aware.scheduler.user.pools.loader.params can be
set to any of the following
+ *
+ * <p><code>
+ * {"artifactory.config.loader.uri":
"http://artifactory.example.org:9989/artifactory/confs/my_cluster/mt_user_pool"}
+ *
+ * {"artifactory.config.loader.uri":
"file:///confs/my_cluster/mt_user_pool"}
+ *
+ * {"artifactory.config.loader.uri":
"file:///confs/my_cluster/mt_user_pool",
"artifactory.config.loader.timeout.secs" : "60"}
+ * </code>
+ *
+ */
+public class ArtifactoryConfigLoader implements IConfigLoader {
+ protected static final String ARTIFACTORY_URI =
"artifactory.config.loader.uri";
+ protected static final String ARTIFACTORY_TIMEOUT_SECS =
"artifactory.config.loader.timeout.secs";
+ protected static final String ARTIFACTORY_POLL_TIME_SECS =
"artifactory.config.loader.polltime.secs";
+ protected static final String ARTIFACTORY_SCHEME =
"artifactory.config.loader.scheme";
+ protected static final String ARTIFACTORY_BASE_DIRECTORY =
"artifactory.config.loader.base.directory";
+ protected static final String LOCAL_ARTIFACT_DIR =
"scheduler_artifacts";
+ static final String cacheFilename = "latest.yaml";
+
+ private static final Logger LOG =
LoggerFactory.getLogger(ArtifactoryConfigLoader.class);
+
+ @SuppressWarnings("rawtypes")
+ private Map _conf;
+ private int _artifactoryPollTimeSecs = 600;
+ private boolean _cacheInitialized = false;
+ // Location of the file in the artifactory archive. Also used to name
file in cache.
+ private String _localCacheDir;
+ private String _artifactoryScheme = "http";
+ private String _baseDirectory = "/artifactory";
+ private int _lastReturnedTime = 0;
+ private int _timeoutSeconds = 10;
+ private Map _lastReturnedValue;
+
+ /**
+ * A private class used to check the response coming back from
httpclient.
+ */
+ private static class GETStringResponseHandler implements
ResponseHandler<String> {
+ private static GETStringResponseHandler singleton = null;
+
+ /**
+ * @return a singleton httpclient GET response handler
+ */
+ public static GETStringResponseHandler getInstance() {
+ if (singleton == null) {
+ singleton = new GETStringResponseHandler();
+ }
+ return singleton;
+ }
+
+ @Override
+ /**
+ * @param response The http response to verify.
+ *
+ * @return null on failure or the response string if return code
is in 200 range
+ */
+ public String handleResponse(final HttpResponse response) throws
IOException {
+ int status = response.getStatusLine().getStatusCode();
+ if (status >= 200 && status < 300) {
+ HttpEntity entity = response.getEntity();
+ return entity != null ? EntityUtils.toString(entity) :
null;
+ } else {
+ LOG.error("Got unexpected response code {}", status);
+ return null;
+ }
+ }
+ }
+
+ /**
+ * @param api null if we are trying to download artifact, otherwise a
string to call REST api,
+ * e.g. "/api/storage"
+ * @param artifact location of artifact
+ * @param host Artifactory hostname
+ * @param port Artifactory port
+ *
+ * @return null on failure or the response string if return code is in
200 range
+ *
+ * <p>Protected so we can override this in unit tests
+ */
+ protected String doGet(String api, String artifact, String host,
Integer port) {
+ URIBuilder builder = new
URIBuilder().setScheme(_artifactoryScheme).setHost(host).setPort(port);
+
+ String path = null;
+ if (api != null) {
+ path = _baseDirectory + "/" + api + "/" + artifact;
+ } else {
+ path = _baseDirectory + "/" + artifact;
+ }
+
+ // Get rid of multiple '/' in url
+ path = path.replaceAll("/[/]+", "/");
+ builder.setPath(path);
+
+ RequestConfig requestConfig =
RequestConfig.custom().setConnectTimeout(_timeoutSeconds * 1000).build();
+ HttpClient httpclient =
HttpClientBuilder.create().setDefaultRequestConfig(requestConfig).build();
+
+ String returnValue;
+ try {
+ LOG.debug("About to issue a GET to {}", builder);
+ HttpGet httpget = new HttpGet(builder.build());
+
+ String responseBody;
+ responseBody = httpclient.execute(httpget,
GETStringResponseHandler.getInstance());
+ returnValue = responseBody;
+ } catch (Exception e) {
+ LOG.error("Received exception while connecting to
Artifactory", e);
+ returnValue = null;
+ }
+
+ LOG.debug("Returning {}",returnValue);
+ return returnValue;
+ }
+
+ private JSONObject getArtifactMetadata(String location, String host,
Integer port) {
+ String metadataStr = null;
+
+ metadataStr = doGet("/api/storage", location, host, port);
+
+ if (metadataStr == null) {
+ return null;
+ }
+
+ JSONObject returnValue;
+ try {
+ returnValue = (JSONObject) new JSONParser().parse(metadataStr);
+ } catch (ParseException e) {
+ LOG.error("Could not parse JSON string {}", metadataStr, e);
+ return null;
+ }
+
+ return returnValue;
+ }
+
+ private class DirEntryCompare implements Comparator<JSONObject> {
+ @Override
+ public int compare(JSONObject o1, JSONObject o2) {
+ return
((String)o1.get("uri")).compareTo((String)o2.get("uri"));
+ }
+ }
+
+ private String loadMostRecentArtifact(String location, String host,
Integer port) {
+ // Is this a directory or is it a file?
+ JSONObject json = getArtifactMetadata(location, host, port);
+ if (json == null) {
+ LOG.error("got null metadata");
+ return null;
+ }
+ String downloadURI = (String) json.get("downloadUri");
+
+ // This means we are pointing at a file.
+ if (downloadURI != null) {
+ // Then get it and return the file as string.
+ String returnValue = doGet(null, location, host, port);
+ saveInArtifactoryCache(returnValue);
--- End diff --
`saveInArtifactoryCache` checks for null. I know it is not as readable
here, but it does look like it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
