Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r135995091
  
    --- Diff: conf/defaults.yaml ---
    @@ -231,20 +234,35 @@ topology.multilang.serializer: 
"org.apache.storm.multilang.JsonSerializer"
     topology.shellbolt.max.pending: 100
     topology.skip.missing.kryo.registrations: false
     topology.max.task.parallelism: null
    -topology.max.spout.pending: null
    +topology.max.spout.pending: 995  # Used in ACK mode only. Should be less 
than `topology.executor.receive.buffer.size` to avoid deadlocked cycles 
involving ACKer
    --- End diff --
    
    We may want to flow ACK tuples and metrics tuples even backpressure is now 
in place, given that we treat them as the thing should be handled ASAP. Given 
that we have tuple timeout, delaying ACK tuples could make tuple being failed 
and retry even tuple tree is actually completed in worst case. I myself is also 
not 100% sure, and that's a hard thing to verify and consider so OK to file a 
follow-up issue if we agree on such issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to