Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r135689031
  
    --- Diff: conf/defaults.yaml ---
    @@ -231,20 +234,35 @@ topology.multilang.serializer: 
"org.apache.storm.multilang.JsonSerializer"
     topology.shellbolt.max.pending: 100
     topology.skip.missing.kryo.registrations: false
     topology.max.task.parallelism: null
    -topology.max.spout.pending: null
    +topology.max.spout.pending: 995  # Used in ACK mode only. Should be less 
than `topology.executor.receive.buffer.size` to avoid deadlocked cycles 
involving ACKer
    --- End diff --
    
    Do we need this since we addressed the netty unbounded buffering? Its a 
pain to tune multiple parameters to achieve back-pressure and right now 
max.spout.pending also needs to be tuned to get application logic like 
windowing to work correctly. IMO, we can try to get rid of this config if 
possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to