[GitHub] storm pull request #2309: (1.x) STORM-2724 Shutdown ExecutorService in Water...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2309#discussion_r137663770
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/windowing/WaterMarkEventGenerator.java ---
    @@ -126,4 +135,20 @@ private void checkFailures() {
         public void start() {
             this.executorFuture = executorService.scheduleAtFixedRate(this, 
interval, interval, TimeUnit.MILLISECONDS);
         }
    +
    +    public void shutdown() {
    +        LOG.debug("Shutting down WaterMarkEventGenerator");
    +        if (this.executorService != null) {
    --- End diff --
    
    Same here. Will address.


---