[GitHub] storm pull request #2309: (1.x) STORM-2724 Shutdown ExecutorService in Water...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2309#discussion_r137663649
  
    --- Diff: 
storm-core/test/jvm/org/apache/storm/windowing/WaterMarkEventGeneratorTest.java 
---
    @@ -56,6 +57,13 @@ public void add(Event<Integer> event) {
             waterMarkEventGenerator.start();
         }
     
    +    @After
    +    public void tearDown() {
    +        if (waterMarkEventGenerator != null) {
    --- End diff --
    
    Yes I just add it as defensive progressing, but can be removed. I'll 
address.


---