Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2343#discussion_r141187945
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
 ---
    @@ -0,0 +1,248 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.scheduler.blacklist;
    +
    +import com.google.common.collect.EvictingQueue;
    +import org.apache.storm.DaemonConfig;
    +import org.apache.storm.metric.StormMetricsRegistry;
    +import org.apache.storm.scheduler.Cluster;
    +import org.apache.storm.scheduler.IScheduler;
    +import org.apache.storm.scheduler.SupervisorDetails;
    +import org.apache.storm.scheduler.Topologies;
    +import org.apache.storm.scheduler.WorkerSlot;
    +import org.apache.storm.scheduler.blacklist.reporters.IReporter;
    +import org.apache.storm.scheduler.blacklist.reporters.LogReporter;
    +import 
org.apache.storm.scheduler.blacklist.strategies.DefaultBlacklistStrategy;
    +import org.apache.storm.scheduler.blacklist.strategies.IBlacklistStrategy;
    +import org.apache.storm.utils.ObjectReader;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.Map;
    +import java.util.Set;
    +import java.util.concurrent.Callable;
    +
    +public class BlacklistScheduler implements IScheduler {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(BlacklistScheduler.class);
    +
    +    public static final int DEFAULT_BLACKLIST_SCHEDULER_RESUME_TIME = 1800;
    +    public static final int DEFAULT_BLACKLIST_SCHEDULER_TOLERANCE_COUNT = 
3;
    +    public static final int DEFAULT_BLACKLIST_SCHEDULER_TOLERANCE_TIME = 
300;
    +
    +    private final IScheduler underlyingScheduler;
    +    @SuppressWarnings("rawtypes")
    +    private Map _conf;
    --- End diff --
    
    Can we change this to `conf` which will fix one of the violations.


---

Reply via email to