[GitHub] storm pull request #2343: STORM-2083 Blacklist scheduler

[revans2]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2343#discussion_r141187500
  
    --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
    @@ -103,6 +110,38 @@
         public static final String STORM_SCHEDULER = "storm.scheduler";
     
         /**
    +     * The number of seconds that the blacklist scheduler will concern of 
bad slots or supervisors
    +     */
    +    @isInteger
    +    public static final String BLACKLIST_SCHEDULER_TOLERANCE_TIME = 
"blacklist.scheduler.tolerance.time.secs";
    +
    +    /**
    +     * The number of hit count that will trigger blacklist in tolerance 
time
    +     */
    +    @isInteger
    --- End diff --
    
    Is a negative count allowed?  If not we should also mark it as 
`@isPositiveNumber`
    
    Same for tolerance time and resume time.


---