I am +1 to releasing 1.1.2 right away. I am in the middle of one review but I will finish it in the next day, such that we can get this merged soon.
However, we need to hold onto releasing 1.2.0 until some of the changes for ProcessingGuarantee that got in this patch<https://github.com/apache/storm/commit/48f6969027e7b02a5b9220577189d3911aa2226d> are fixed. I briefly discussed [1] this issue with @Stig on Gitter, I will submit a patch with the change. Thanks, Hugo [1] - We did not have a technical discussion. I just asked a couple of clarifying questions and then the idea surged that we should improve some of the changes in this patch<https://github.com/apache/storm/commit/48f6969027e7b02a5b9220577189d3911aa2226d>. I will create a JIRA, and all the discussion go through either JIRA or dev email list. On Oct 10, 2017, at 12:48 PM, Stig Rohde Døssing <[email protected]<mailto:[email protected]>> wrote: Thanks Jungtaek, that sounds like a good plan. Here's the new PR for 2607 https://github.com/apache/storm/pull/2367. Beginning release next week sounds good to me. 2017-10-10 17:42 GMT+02:00 Arun Mahadevan <[email protected]<mailto:[email protected]>>: +1 for addressing the pending reviews and getting 1.2.0 out soon. On 10/10/17, 6:14 AM, "Jungtaek Lim" <[email protected]<mailto:[email protected]>> wrote: Stig, Let's just handle all the issues pending Storm 1.1.2. For pending issues on Storm 1.2.0, I already handled all the things. For STORM-2607, could you just take over and craft a new pull request? We are waiting more than 2 months after requesting simple rebase (sadly it is not done yet), which I don't think it's acceptable. That issue relates a bug which we should handle it in time. (The patch includes your work indeed.) For STORM-2549, let's see someone could review in this week. I'll try to get it too. Then I think we can start release phase for Storm 1.1.2 and 1.2.0 at next week. Opinions anyone? Thanks, Jungtaek Lim (HeartSaVioR) 2017년 10월 10일 (화) 오전 4:02, Stig Rohde Døssing <[email protected]<mailto:[email protected]>>님이 작성: Maybe we would be better off releasing 1.1.2 as is, and postponing the other issues to 1.2.0? I don't think we should delay the fix for https://issues.apache.org/jira/browse/STORM-2682 for much longer. 2017-09-22 14:50 GMT+02:00 Alexandre Vermeerbergen < [email protected]<mailto:[email protected]> : Hello, I don't know if that help, but we're still waiting with lots of expectations https://issues.apache.org/jira/browse/STORM-2648 with Storm 1.2.0 ! Best regards, Alexandre Vermeerbergen 2017-09-22 12:24 GMT+02:00 Jungtaek Lim <[email protected]<mailto:[email protected]>>: Looks like three weeks went by from initiating the thread. I'm seeing some issues pending for review and all of them are regarding storm-kafka-client. Remaining issues are below: Storm 1.1.2 https://issues.apache.org/jira/browse/STORM-2549 https://issues.apache.org/jira/browse/STORM-2607 https://issues.apache.org/jira/browse/STORM-2666 Storm 1.2.0 https://issues.apache.org/jira/browse/STORM-2648 Please note that above issues are 'effectively' blocker for releases. Like I said Storm 1.1.1 has critical issue which is fixed and will be available at Storm 1.1.2, so at least I'd like to see the progress on Storm 1.1.2, and ideally with Storm 1.2.0 since there's only one issue left on epic. Please finish reviewing if you are in reviewing one or more of them. I'll try to start reviewing them but take some times since I'm not familiar with that module. Thanks, Jungtaek Lim (HeartSaVioR) 2017년 8월 30일 (수) 오전 2:45, P. Taylor Goetz <[email protected]<mailto:[email protected]>>님이 작성: It looks to me like 1.0.5 is ready for a release candidate (still some ongoing work for 1.1.2, but likely soon). Is there anything else we would want to include in 1.0.5 or should we go ahead with a release? -Taylor On Aug 25, 2017, at 3:26 AM, Jungtaek Lim <[email protected]<mailto:[email protected]>> wrote: Hi devs, We received a bug report (STORM-2682 <https://issues.apache.org/jira/browse/STORM-2682>) on Storm 1.0.4 and 1.1.1 which prevents Storm cluster from update. Personally it looks like pretty critical, and hopefully it is fixed now. So maybe we would like to have another bug fix releases quickly for affected 1.x version lines. What do you think? Also please enumerate the issues if you would want to include any bug fix issues to the new bug fix releases, so that we can create epic issues and track them to make releases happening sooner. Thanks, Jungtaek Lim (HeartSaVioR)
