Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236218
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,62 +553,70 @@ public boolean wouldFit(
WorkerSlot ws,
ExecutorDetails exec,
TopologyDetails td,
- double maxHeap,
- double memoryAvailable,
- double cpuAvailable) {
- //NOTE this is called lots and lots by schedulers, so anything we
can do to make it faster is going to help a lot.
- //CPU is simplest because it does not have odd interactions.
- double cpuNeeded = td.getTotalCpuReqTask(exec);
- if (cpuNeeded > cpuAvailable) {
- if (LOG.isTraceEnabled()) {
- LOG.trace("Could not schedule {}:{} on {} not enough CPU
{} > {}",
- td.getName(),
- exec,
- ws,
- cpuNeeded,
- cpuAvailable);
+ Map<String, Double> resourcesAvailable,
+ double maxHeap) {
+
+ Map<String, Double> requestedResources =
td.getTotalResources(exec);
+
+ LOG.info(td.getName());
+ LOG.info("requested");
+ LOG.info(requestedResources.toString());
+ LOG.info("available");
+ LOG.info(resourcesAvailable.toString());
+ LOG.info(ws.toString());
--- End diff --
I think this is debug logging. Can we please remove it?
---
