[GitHub] storm pull request #2385: STORM-2727: Generic Resource Aware Scheduling

[revans2]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2385#discussion_r147236780
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
    @@ -664,6 +722,9 @@ private double calculateSharedOffHeapMemory(String 
nodeId, SchedulerAssignmentIm
     
         private double calculateSharedOffHeapMemory(
             String nodeId, SchedulerAssignmentImpl assignment, ExecutorDetails 
extra) {
    +        if (assignment == null) {
    --- End diff --
    
    When is the assignment null???  Why would we try to calculate the shared 
off heap memory for no assignment???


---