Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152896601
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -228,6 +257,51 @@ private void launchDaemon() {
}
}
+ private void launchSupervisorThriftServer(Map conf) throws IOException
{
+ // validate port
+ try {
+ ServerSocket socket = new
ServerSocket(ObjectReader.getInt(conf.get(Config.SUPERVISOR_THRIFT_PORT)));
--- End diff --
Maybe better to extract a variable for
`conf.get(Config.SUPERVISOR_THRIFT_PORT)` given that it's used for 3 times in
several lines.
---
