Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152903015
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SynchronizeAssignments.java
---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.supervisor.timer;
+
+import org.apache.storm.cluster.IStormClusterState;
+import org.apache.storm.daemon.supervisor.ReadClusterState;
+import org.apache.storm.daemon.supervisor.Supervisor;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.SupervisorAssignments;
+import org.apache.storm.utils.ConfigUtils;
+import org.apache.storm.utils.NimbusClient;
+import org.apache.storm.utils.Utils;
+import org.apache.thrift.TException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * A runnable which will synchronize assignments to node local and then
worker processes.
+ */
+public class SynchronizeAssignments implements Runnable {
+ private static final Logger LOG =
LoggerFactory.getLogger(SynchronizeAssignments.class);
+
+ private Supervisor supervisor;
+ private SupervisorAssignments assignments;
+ private ReadClusterState readClusterState;
+
+ public SynchronizeAssignments(Supervisor supervisor,
SupervisorAssignments assignments, ReadClusterState readClusterState) {
+ this.supervisor = supervisor;
+ this.assignments = assignments;
+ this.readClusterState = readClusterState;
+ }
+
+ @Override
+ public void run() {
+ // first sync assignments to local, then sync processes.
+ if (null == assignments) {
+ getAssignmentsFromMaster(this.supervisor.getConf(),
this.supervisor.getStormClusterState(), this.supervisor.getAssignmentId());
+ } else {
+
assignedAssignmentsToLocal(this.supervisor.getStormClusterState(), assignments);
+ }
+ this.readClusterState.run();
+ }
+
+ /**
+ * Used by {@link Supervisor} to fetch assignments when start up.
+ * @param supervisor
+ */
+ public void getAssignmentsFromMasterUntilSuccess(Supervisor
supervisor) {
+ boolean success = false;
+ NimbusClient master;
+ while (!success) {
+ try {
+ master =
NimbusClient.getConfiguredClient(supervisor.getConf());
+ SupervisorAssignments assignments =
master.getClient().getSupervisorAssignments(supervisor.getAssignmentId());
+
assignedAssignmentsToLocal(supervisor.getStormClusterState(), assignments);
+ success = true;
+ try {
+ master.close();
+ } catch (Throwable t) {
+ LOG.warn("Close master client exception", t);
+ }
+ } catch (Exception t) {
+ // just ignore the exception
+ }
+ if (!success) {
+ LOG.info("Waiting for a success sync of assignments from
master...");
+ try {
+ Thread.sleep(5000l);
--- End diff --
Let's use `Time.sleep()`.
---
