Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r155640453
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/filters/StormMetricsFilter.java ---
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.metrics2.filters;
+
+import com.codahale.metrics.MetricFilter;
+
+import java.util.Map;
+
+public interface StormMetricsFilter extends MetricFilter {
+
+ /**
+ * Called after the filter is instantiated.
+ * @param config an arbitrary configuration map pulled from the yaml
configuration.
--- End diff --
Nit: I don't feel like this comment really explain what'll be in the config
map. How about "A map of the properties from the 'filter' section of the
reporter configuration" or something like that?
---
