Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r155640205
  
    --- Diff: conf/defaults.yaml ---
    @@ -293,3 +293,28 @@ storm.daemon.metrics.reporter.plugins:
     
     # configuration of cluster metrics consumer
     storm.cluster.metrics.consumer.publish.interval.secs: 60
    +
    +
    +# Metrics v2 configuration (optional)
    +#storm.metrics.reporters:
    +#  # Graphite Reporter
    +#  - class: "org.apache.storm.metrics2.reporters.GraphiteStormReporter"
    +#    daemons:
    +#        - "supervisor"
    +#        - "nimbus"
    +#        - "worker"
    +#    report.period: 60
    +#    report.period.units: "SECONDS"
    +#    graphite.host: "localhost"
    +#    graphite.port: 2003
    +#
    +#  # Console Reporter
    +#  - class: "org.apache.storm.metrics2.reporters.ConsoleStormReporter"
    +#    daemons:
    +#        - "worker"
    +#    report.period: 10
    +#    report.period.units: "SECONDS"
    +#
    +#    filter:
    --- End diff --
    
    Nit: Move this up a line. I wasn't sure this belonged to the console 
reporter at first.


---

Reply via email to